I know you mentioned that you were adding more diags, but this one would be good if it was in the mix please. It is a community phyto diag for fixed N.
There are two parts - adding the diag (easy), but also suggesting a change that looks like it precludes the fixed N moles being recorded in position 4 of the N uptake array. The boolean flag "do_N2uptake" doesn't look to be set anywhere, or used anywhere except in writing this moles on fixed N to nuptake. It is always false so as an AND logical it stops writing to nuptake(phi,4) in bio_utils. This pull request is to suggest removing this logic and reporting the outcome to a new diag var.
Hi Matt
I know you mentioned that you were adding more diags, but this one would be good if it was in the mix please. It is a community phyto diag for fixed N.
There are two parts - adding the diag (easy), but also suggesting a change that looks like it precludes the fixed N moles being recorded in position 4 of the N uptake array. The boolean flag "do_N2uptake" doesn't look to be set anywhere, or used anywhere except in writing this moles on fixed N to nuptake. It is always false so as an AND logical it stops writing to nuptake(phi,4) in bio_utils. This pull request is to suggest removing this logic and reporting the outcome to a new diag var.
Thanks MB