issue with atm_din flux

AquaticEcoDynamics / libaed-water

Code for the AED water quality model

GNU General Public License v3.0

6 stars 6 forks source link

issue with atm_din flux #42

Closed aed-modeller closed 2 years ago

aed-modeller commented 2 years ago

https://github.com/AquaticEcoDynamics/libaed-water/blob/19a6b2aad2b67a2a8d8cbc7a8ea4f74e7dba0b9c/src/aed_nitrogen.F90#L608

The ATM_DIN flux output doesn't look right. It keeps accmulating with time, but the NO3 and NH4 concentration in the water was not impacted. Possibly same issue with the ATM DIP flux 0007_A4261165 nutrient_budget_nitrogen_timeseries

matthipsey commented 2 years ago

Hi Peisheng I think this is the same issues, as raised here: https://github.com/AquaticEcoDynamics/libaed-water/pull/27

I think it is fixed in the latest code, and will work when you use the newer binary. Matt