AquaticEcoDynamics / libaed-water

Code for the AED water quality model
GNU General Public License v3.0
6 stars 6 forks source link

a bug in the MPB update #50

Open aed-modeller opened 2 years ago

aed-modeller commented 2 years ago

https://github.com/AquaticEcoDynamics/libaed-water/blob/a27a543d9f53aaf3c5cd7ff68f051fc2b8b11828/src/aed_phytoplankton.F90#L1308

This look like a bug because the variable mpb in this code was the MPB biomass from previous timestep, and was not updated during the calculations, so at the end the MPB biomass is alway the same although growth and respiration were calculated.