As it stands, the new phy sedimentation diags do not account for phyto groups that do not simulate IN and IP. This makes the phy diag settling N and P diags hard to interpret, and doesn't allow for TN and TP mass balances to hold. This suggested modification adds the IN and IP entering the sediments within phyto groups that do not simulate internal nutrients (simINDynamics and simIPDynamics = 0). I have tested the modifications and mass balance holds to within 0.015% over a month long simulation.
I have not looked at resus, but I am guessing that a similar modification might be needed for the corresponding diag calculation, otherwise the mass balance will fail. I have not included that code modification in this pull request.
Hi Matt
This is similar to pull requests https://github.com/AquaticEcoDynamics/libaed-water/pull/51 and https://github.com/AquaticEcoDynamics/libaed-water/pull/52.
As it stands, the new phy sedimentation diags do not account for phyto groups that do not simulate IN and IP. This makes the phy diag settling N and P diags hard to interpret, and doesn't allow for TN and TP mass balances to hold. This suggested modification adds the IN and IP entering the sediments within phyto groups that do not simulate internal nutrients (simINDynamics and simIPDynamics = 0). I have tested the modifications and mass balance holds to within 0.015% over a month long simulation.
I have not looked at resus, but I am guessing that a similar modification might be needed for the corresponding diag calculation, otherwise the mass balance will fail. I have not included that code modification in this pull request.
MB