Closed MichaelBarryBMT closed 2 years ago
matthipsey
commented
2 years ago MB, Just need to be careful here as aed_nitrogen is also participating in denitrification. The intent maybe that in this case amm is already being incremented in aed_nitrogen so doesn't need to be here. I'll take a closer look
MichaelBarryBMT
commented
2 years ago Ta!
Dr Michael Barry Senior Principal Engineer Adjunct Associate Professor, Southern Cross University @.***https://www.tuflow.com/ TUFLOW Productshttps://www.tuflow.com/products/ | TUFLOW Pricinghttps://www.tuflow.com/pricing/ | TUFLOW Supporthttps://www.tuflow.com/support/ | TUFLOW Traininghttps://www.tuflow.com/training/ | LinkedInhttps://www.linkedin.com/groups/1908583/ | YouTubehttps://www.youtube.com/channel/UCZuGrIP8ayOwC1ojmnZrgPg The Latest TUFLOW FV Release 2020.03 is now available: Release Noteshttps://downloads.tuflow.com/TUFLOWFV/Release_Notes/TUFLOW_FV_Release_Notes_2020.pdf | Downloads Pagehttps://www.tuflow.com/downloads/#tuflow_fv
From: Matt Hipsey @.> Sent: 23 March 2022 15:11 To: AquaticEcoDynamics/libaed-water @.> Cc: Michael Barry @.>; Author @.> Subject: [External] Re: [AquaticEcoDynamics/libaed-water] Suggested SimDenitrification modification (PR #57)
MB, Just need to be careful here as aed_nitrogen is also participating in denitrification. The intent maybe that in this case ams is already being incremented in aed_nitrogen so doesn't need to be here. I'll take a closer look
— Reply to this email directly, view it on GitHubhttps://github.com/AquaticEcoDynamics/libaed-water/pull/57#issuecomment-1075919884, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AWW5ACGG3CA6LFXHGVJHQ2LVBKRURANCNFSM5RJYR4OA. You are receiving this because you authored the thread.Message ID: @.**@.>>
This email has been scanned for viruses and malware Mimecast Ltd.
matthipsey
commented
2 years ago MB - you are right, this DON mineralisation was getting lost if simDenitrification = 0. Ive updated on my side and checked in
Hi Matt
It may be that when SimDenitrification = 0, don_mineralisation mmol is removed from DON but not added to any other state variables. This causes mass balance issues on ammonium. Removing the single IF statement suggested in this pull request fixes this issue: denitrification is zero, but DON still mineralises to ammonium and is accounted for correctly.