search

AquaticEcoDynamics / libaed-water

Code for the AED water quality model
GNU General Public License v3.0
6 stars 6 forks source link

trouble with theta_resp_zoo #68

Open hlwander opened 6 months ago

hlwander commented 6 months ago

https://github.com/AquaticEcoDynamics/libaed-water/blob/f8e8f7219639596baef79347450cc0bb5a06fc7a/src/aed_zooplankton.F90#L354

The theta_resp_zoo parameter only allows for integer values. When I try to use a value between 1 and 2 (e.g., 1.06), the model crashes (see screenshot below)

Screenshot 2024-03-29 at 1 52 03 PM
matthipsey commented 6 months ago

Hi Heather

I’ve made the fix just now (obvious file read error) https://github.com/AquaticEcoDynamics/libaed-water/commit/4fe1b27b97f2eba35693c586cd7ef27e2c0d56a8

If your compiling this at VT, then re-sync and go, otherwise if you need a new pre-compiled binary I'll have to update via glm-aed repo.

I'll leave the issue open for now until we can do a test

Cheers Matt