search

AquaticEcoDynamics / libaed2

Code for the AED2 water quality / ecology library
http://aquatic.science.uwa.edu.au/research/models/AED/
GNU General Public License v3.0
14 stars 17 forks source link

Segmentation fault with simCH4ebb=true #19

Open f-baerenbold opened 3 years ago

f-baerenbold commented 3 years ago

Hi,

If simCH4ebb is true (or undefined) in the config file, I get a segfault in my Simstrat-AED2 model. I found out that it is related to the following warning during compilation of AED2:

src/aed2_carbon.F90:715:0:

   _DIAG_VAR_S_(data%id_atm_ch4_ebb) = ebb_flux * (1-data%ch4_bub_disf1) * secs_per_day

Warning: 'ebb_flux' may be used uninitialized in this function [-Wmaybe-uninitialized]

matthipsey commented 3 years ago

Hi Fabian

Thanks for picking this up - there is a mismatch in the declaration and then its use here, as to whether its a water column or "sheet" variable - we'll fix and check, and then update.

Apologies we didn't catch this before checking it in

Thanks Matt

From: Fabian Bärenbold notifications@github.com Sent: Friday, 6 November 2020 12:20 AM To: AquaticEcoDynamics/libaed2 libaed2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [AquaticEcoDynamics/libaed2] Segmentation fault with simCH4ebb=true (#19)

Hi,

If simCH4ebb is true (or undefined) in the config file, I get a segfault in my Simstrat-AED2 model. I found out that it is related to the following warning during compilation of AED2:

src/aed2_carbon.F90:715:0:

_DIAG_VARS(data%id_atm_ch4_ebb) = ebb_flux (1-data%ch4_bub_disf1) secs_per_day

Warning: 'ebb_flux' may be used uninitialized in this function [-Wmaybe-uninitialized]

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAquaticEcoDynamics%2Flibaed2%2Fissues%2F19&data=04%7C01%7Cmatt.hipsey%40uwa.edu.au%7C225694c2493c4d4c6fb408d881a6aa96%7C05894af0cb2846d8871674cdb46e2226%7C1%7C0%7C637401900115556059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=t21ekn%2BVn0bExWcPD3ayFAeFCznWrK%2Bpd8%2Fj6rhgoX0%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAB2QIDP5ZV3JUTHUGTOXBOLSOLGDBANCNFSM4TLSFOVA&data=04%7C01%7Cmatt.hipsey%40uwa.edu.au%7C225694c2493c4d4c6fb408d881a6aa96%7C05894af0cb2846d8871674cdb46e2226%7C1%7C0%7C637401900115556059%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6COOWmo7hQfhplB0jKGb4iCjH714iTFvsJUb%2BZ7YffU%3D&reserved=0.

f-baerenbold commented 3 years ago

Ok, thanks!

Cheers, Fabian