matthipsey
commented
11 months ago Hi Ciaran
Just checking if you are referring to AED2 to or AED? AED2 has been retired a few years back and is available here but we don’t really continue to develop it.
The main version of GLM we distribute is GLM-AED (https://github.com/AquaticEcoDynamics/glm-aed), and this uses the various libraries that make up AED, including libaed-water
I will dig a little deeper, but I think its possible the diagnostic issues were taken care of in AED after it forked off from AED2. https://github.com/AquaticEcoDynamics/libaed-water/blob/a0484c5b5f946aa4a4635520410974be083a925d/src/aed_phosphorus.F90#L419 https://github.com/AquaticEcoDynamics/libaed-water/blob/a0484c5b5f946aa4a4635520410974be083a925d/src/aed_organic_matter.F90#L1195
If you prefer AED2, then these fixes can be copied back into it, but note there a lot more advances in AED over and above AED2 that I would suggest its worth the upgrade.
Cheers Matt
From: Ciaran J. Harman @.> Date: Friday, 4 August 2023 at 3:55 am To: AquaticEcoDynamics/libaed2 @.> Cc: Subscribed @.***> Subject: [AquaticEcoDynamics/libaed2] PHS_atm_dip_flux diagnostic variable (Issue #21)
In my aed2.nml file I have simDryDeposition = .TRUE. atm_pip_dd = 0.004 simWetDeposition = .TRUE. atm_frp_conc = 1.8 but in the resulting .nc file the value of PHS_atm_dip_flux is all zeros. If I change the 0.004 and 1.8 to 0.0 and 0.0 the results change, suggesting that atmospheric deposition is being accounted for, but the diagnostic variable is not being reported. I also find that OGM_sed_dop is all zeros, though OGM_sed_pop is not. Is it possible there is a bug in the calculation of these?
— Reply to this email directly, view it on GitHubhttps://github.com/AquaticEcoDynamics/libaed2/issues/21, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB2QIDMQVGI5U5RZ5MCW3Z3XTP63RANCNFSM6AAAAAA3DIEKP4. You are receiving this because you are subscribed to this thread.Message ID: @.***>
In my aed2.nml file I have simDryDeposition = .TRUE. atm_pip_dd = 0.004 simWetDeposition = .TRUE. atm_frp_conc = 1.8 but in the resulting .nc file the value of PHS_atm_dip_flux is all zeros. If I change the 0.004 and 1.8 to 0.0 and 0.0 the results change, suggesting that atmospheric deposition is being accounted for, but the diagnostic variable is not being reported. I also find that OGM_sed_dop is all zeros, though OGM_sed_pop is not. Is it possible there is a bug in the calculation of these?