search

Aquaveo / xmscore

Support library for XMS products
BSD 2-Clause "Simplified" License
3 stars 2 forks source link

Pt3d Supports variadic instantiation. Python should too. #10

Closed Tsubashi closed 6 years ago

Tsubashi commented 6 years ago

The helper function that converts from tuples to Pt3d currently requires 3-tuples, but Pt3d doesn't necessarily. We definitely should support 2-tuples, and possibly 1-tuples and empty sets. These should call the appropriate constructor on Pt3d.

https://github.com/Aquaveo/xmscore/blob/d50d2fd618d2ac8b7f87118f7305cd6f1e71b58c/xmscore/python/misc/PyUtils.cpp#L25

alemon-aquaveo commented 6 years ago

approved