AqueductHub / aqueductcore

Aqueduct Core is responsible for the core functionality of Aqueduct, an experiment management system.
https://aqueducthub.github.io/aqueductcore/
MIT License
23 stars 3 forks source link

feat(tags): New mutation to add multiple tags to an experiment. #98

Closed samiralavi closed 1 month ago

samiralavi commented 1 month ago

This PR adds a new mutation to add a list of tags to an experiment. The service method is changed to support that and if there are duplicate tags in the request, an error will be returned following the exception. If the tags were already assigned to an experiment, the service safely continues and adds the new tags to the database and experiment. Unit tests and integration tests are added.

github-actions[bot] commented 1 month ago

Coverage

Coverage Report
FileStmtsMissCoverMissing
aqueductcore/backend
   context.py33488%48–52, 59–60
   main.py19479%21–24, 31
   session.py13469%24–28
aqueductcore/backend/models
   orm.py31197%58
aqueductcore/backend/routers
   files.py88298%165–166
   frontend.py241154%22–33, 37
aqueductcore/backend/routers/graphql
   mutations_schema.py39197%42
   query_schema.py41295%64–66
   router.py11191%15
aqueductcore/backend/routers/graphql/mutations
   experiment_mutations.py24196%30
aqueductcore/backend/routers/graphql/resolvers
   experiment_resolver.py25292%28, 36
   tags_resolver.py25388%14, 44, 46
aqueductcore/backend/services
   experiment.py2203285%82, 111–124, 154, 188, 194, 240, 243, 268, 299, 348, 354, 383, 389, 406, 431, 438, 446, 476–482, 489–493, 505–508
   validators.py33294%41, 46
TOTAL8137091% 

Tests Skipped Failures Errors Time
67 0 :zzz: 0 :x: 0 :fire: 9.858s :stopwatch:
samiralavi commented 1 month ago

@str-anger I have pushed changes to address the bug you found along with other suggestions. Please review it and resolve the ones you believe are fine.