Closed samiralavi closed 1 month ago
Coverage Report
File Stmts Miss Cover Missing aqueductcore/backend context.py 33 4 88% 48–52, 59–60 main.py 19 4 79% 21–24, 31 session.py 13 4 69% 24–28 aqueductcore/backend/models orm.py 31 1 97% 58 aqueductcore/backend/routers files.py 88 2 98% 165–166 frontend.py 24 11 54% 22–33, 37 aqueductcore/backend/routers/graphql mutations_schema.py 39 1 97% 42 query_schema.py 41 2 95% 64–66 router.py 11 1 91% 15 aqueductcore/backend/routers/graphql/mutations experiment_mutations.py 24 1 96% 30 aqueductcore/backend/routers/graphql/resolvers experiment_resolver.py 25 2 92% 28, 36 tags_resolver.py 25 3 88% 14, 44, 46 aqueductcore/backend/services experiment.py 220 32 85% 82, 111–124, 154, 188, 194, 240, 243, 268, 299, 348, 354, 383, 389, 406, 431, 438, 446, 476–482, 489–493, 505–508 validators.py 33 2 94% 41, 46 TOTAL 813 70 91%
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
67 | 0 :zzz: | 0 :x: | 0 :fire: | 9.858s :stopwatch: |
@str-anger I have pushed changes to address the bug you found along with other suggestions. Please review it and resolve the ones you believe are fine.
This PR adds a new mutation to add a list of tags to an experiment. The service method is changed to support that and if there are duplicate tags in the request, an error will be returned following the exception. If the tags were already assigned to an experiment, the service safely continues and adds the new tags to the database and experiment. Unit tests and integration tests are added.