AraBlocks / ara-file-manager

Electron-based desktop app to publish and purchase content with ARA
https://ara.one/app
GNU Lesser General Public License v3.0
26 stars 4 forks source link

fix: asar smaller faster and avoids windows long path bug #562

Closed zootella closed 5 years ago

zootella commented 5 years ago

These changes add the flag for asar to mac and win dev and prod build scripts.

asar is a common default for Electron apps and electron-packager.

With this change, paths too long for many Windows apps (including Squirrel) get hidden inside the asar, and the windows build works again.

Packaging with asar lets setup place several hundred rather than several thousand files on the user's disk, increasing the speed and reliability of creating and running installation packages for both mac and windows.

Several months ago, team avoided asar believing that packaging that way may negatively impact UI speed and responsiveness, but @zootella and @bplaster have tested the app with asar, and can't reproduce that behavior now.