search

AraBlocks / ara-module-template

Ara repo template - documentation, github files, Travis CI and ESLint configs
https://ara.one
GNU Lesser General Public License v3.0
1 stars 1 forks source link

Fix linting #27

Closed bplaster closed 5 years ago

bplaster commented 5 years ago

Expected Behavior

Linting passes

Actual Behavior

Linting fails, and doesn't seem to catch shipright.js linting errors

Steps to Reproduce the Problem

  1. npm run lint

Specifications

vipyne commented 5 years ago

This is on Windows platform? @bplaster

madelinecameron commented 5 years ago

I believe this is fixed (95853c8bd83ec12bcfac112df4174fb680f28a5d). The issue was that eslint was reading docs/scripts/*.js so I added docs/ to .eslintignore since everything in docs/ is generated.

I couldn't get it to trigger linting errors for shipright.

bplaster commented 5 years ago

This is on mac. Oh, we're just ignoring shipright linting? Also, by catch, i mean detect. I added shipright to another project and it throws errors.

madelinecameron commented 5 years ago

Nope, Shipright is in scripts/, the offending scripts were in docs/scripts/ which are auto-generated.

I couldn't get any errors from linting here, but definitely point me to the project that is throwing the linting errors and I'll fix the linting errors. :)

madelinecameron commented 5 years ago

OH. I know why it isn't being read in ara-module-template. One sec. :sweat_smile:

madelinecameron commented 5 years ago

(The scripts/**/*.js ignore was from when we didn't produce the scripts in scripts/. Those scripts are no longer in there. But also, it wouldn't pick up shipright if it didn't end in .js so double-edged)