Mainnet improvements (see #154)

AragonBlack / fundraising

Fundraising apps suite for Aragon organizations

https://fundraising.aragon.black/

GNU Affero General Public License v3.0

75 stars 43 forks source link

Mainnet improvements (see #154) #160

Closed xseignard closed 4 years ago

xseignard commented 4 years ago

Trying to fix race condition on collaterals/taps:

Don't overwrite tap values if the AddCollateralToken is arriving after AddTappedToken

xseignard commented 4 years ago

So, after some more checks, the only similar case is the one with orders and claims. If a claim event happens before an order event, there will be a problem.

But since an order and claiming it cannot happen in the same block, we should be good. Right ?

If so, we're good to merge this I guess.

Have a nice weekend.