vincent4vx
commented
1 year ago Hi!
Thanks for the pull request.
So, for the issue on checkstyle is to add a ignore rule on checkstyle.xml :
<module name="SuppressionSingleFilter">
<property name="checks" value="MethodCountCheck" />
<property name="files" value="entity.player.Player" />
</module>but in this particular implementation, the field and accessors for "is active" flag are not necessary and can be removed, so the methods count will drop under the limit.
And to test this you can add a functional test which creates then delete, then get to ensure that the entity is no more accessible, with an addition of a low level test which call manually the database to check the value of column IS_ACTIVE.
I have two suggestion to improve this feature, if you want/have time to do this :
- You can use a nullable datetime field "DELETED_AT", to allow creation of purge worker in the future. And to check if the entity is present, you simply have to add
AND DELETED_AT IS NULL. - Add a method for actually delete the player
Jean-Dv
Hi ! Looking at the issues a little, I decided to implement soft delete of players.
Implementation
Usually a field is used in the database to help the system check whether it is active or not. It is for this reason that I add it and also do some validations for when the data is sent to the client.
Problems
When running the checkstyle I get the following error:
I understand the error, however, I have no idea how to fix it in a "clean" way.