search

Arakula / dasmfw

The DisASseMbler FrameWork
GNU General Public License v2.0
13 stars 4 forks source link

Query on Disassembler Option: multilabel on/off #15

Closed phillipeaton closed 1 year ago

phillipeaton commented 2 years ago

In the Disassembler Options documentation, it has:

multilabel on|off
nomultilabel
can be used to decide whether multiple labels can be set for a single address.
Default is off.

If I set this to on with a 6502 disassembly, it doesn't seem to do anything...but I'm not sure exactly what it should be doing.

The picture below is from the Infiltrator disassembler, it's created mulitple labels for $8100 (which is on line 211), I'm assuming dasmfw multilabel does something similar regarding multiple labels?

image

The picture below is some 6502 code produced by dasmfw with multilabel on, there are multiple calls to a single address TJOC_RTS, but only a single label produced.

image

My info options file is:

image

Any clues?

phillipeaton commented 2 years ago

Additional feedback: If I leave the multilabel option on, some of my labels don't make it into the generated source code file and the later assembly fails. (I recall seeing some warnings somewhere about multilabel, there may be gotchas.)

phillipeaton commented 2 years ago

After seeing the below comment with the context of the other thread, I think that multilabel doesn't work in the way I am expecting, as described earlier in this thread.

You can therefore either Close this Issue or consider it as a Feature Request that I would find very useful!

You can either write label 0d ZP_Color_RAM_PtrX+1 or tell dasmfw that multiple labels are allowed for an address by setting option multilabel on

I'd suggest the first, however - using multiple labels for an address opens a can of very ugly worms.

Originally posted by @Arakula in https://github.com/Arakula/dasmfw/issues/13#issuecomment-1171112837

phillipeaton commented 1 year ago

Moved to Feature suggestion: Show Label Call Addresses