search

ArangoDB-Community / arangodb-net-standard

A consistent, comprehensive, minimal interface to enable .NET applications to use the complete range of features exposed by the ArangoDB REST API.
Apache License 2.0
76 stars 30 forks source link

Fixed dictionary item value serialization issue - Part 2 #445

Closed tjoubert closed 1 year ago

tjoubert commented 1 year ago

Solves Issue #400 This is a follow-on PR from #401 Issues raised in the comments in the old PR have been fixed by this one.

tjoubert commented 1 year ago

Shouldn't we set the new property in the API method the issue was opened for? Otherwise the issue won't be fixed.

You mean in PostCreateViewAsync(). Is it a good idea to hard-code this (i.e. applySerializationOptionsToObjectValuesInDictionaries: true)? Or is it better to allow the caller to pass a ApiClientSerializationOptions instance as a parameter that is null by default for backward compatibility?

tjoubert commented 1 year ago

Good idea to simplify the name. Done.

tjoubert commented 1 year ago

@DiscoPYF , I've also applied these changes to PatchViewPropertiesAsync() and PutViewPropertiesAsync()