ArangoDB-Community / arangodb-net-standard

A consistent, comprehensive, minimal interface to enable .NET applications to use the complete range of features exposed by the ArangoDB REST API.
Apache License 2.0
77 stars 30 forks source link

Fix #484: Use IEnumerable<T> instead of IList<T>. #485

Closed rossmills99 closed 11 months ago

rossmills99 commented 11 months ago

Fix #484 by using IEnumerable in place of IList.

I've ended up expanding from the issue description to also update all places we used IList in interfaces and models.

As far as I can tell, this should not be a breaking change because every IList<T> is already an IEnumerable<T>, but IEnumerable<T> allows for greater flexibility in choice of the actual collection type implementations used.

Arash-Sabet commented 11 months ago

@rossmills99 Is this release's Nuget package available?

DiscoPYF commented 11 months ago

@rossmills99 Is this release's Nuget package available?

Hey @Arash-Sabet , I would like to clarify the questions above with @rossmills99 before releasing this enhancement. We can get it out once done 👍

Depending on the outcome, it will be in a patch release, 2.0.2 or minor release 2.1.0

Arash-Sabet commented 11 months ago

Hey @rossmills99 & @DiscoPYF

Do you happen to know when you're planning to release the patch or minor release as the enhancements in our side are pending for your changes.

rossmills99 commented 11 months ago

Per discussion above we can release as 3.0.0 along with a couple of other recently added improvements. I can prepare a release to go out today.

Arash-Sabet commented 11 months ago

@rossmills99 thanks for the prompt action.

rossmills99 commented 11 months ago

@rossmills99 thanks for the prompt action.

No problem, thanks for the prompt 😄

The 3.0.0 package is now published in Nuget, you can view release notes here: https://github.com/ArangoDB-Community/arangodb-net-standard/releases/tag/3.0.0