search

ArangoDB-Community / arangodb-net-standard

A consistent, comprehensive, minimal interface to enable .NET applications to use the complete range of features exposed by the ArangoDB REST API.
Apache License 2.0
76 stars 30 forks source link

Fix #479 Add tests for ArangoDB 3.11. #486

Closed rossmills99 closed 11 months ago

rossmills99 commented 11 months ago

479 Adds tests for ArangoDB 3.11

rossmills99 commented 11 months ago

Interesting... appears to be a broken test which starts breaking with some minor version of 3.10.x (before these changes, the tests ran against 3.10.0 and worked fine. Now I've updated so they run on the most recent patch version, and one of them is failing).

Now trying to reproduce locally.

rossmills99 commented 11 months ago

image

The documentation doesn't mention a "Code" property in the response. The failing test is checking the "Code" property for a match on HttpStatus.OK. However the value of "Code" property is no longer 200 (OK) but is 0. I expect some change was made and the code is not being set any more in the ArangoDB backend. Since it isn't a documented part of the API, I think just removing the check from the test is an appropriate course of action.

DiscoPYF commented 11 months ago

Since it isn't a documented part of the API, I think just removing the check from the test is an appropriate course of action.

This one is minor but I wouldn't rely on the API documentation being up to date. We found so many instances where properties aren't documented as they should.