Decouple shouldPrefixCollectionNames with DB creation

ArangoDB-Community / arangodb-tinkerpop-provider

An implementation of the Tinkerpop OLTP Provider for ArangoDB

Apache License 2.0

84 stars 16 forks source link

Decouple shouldPrefixCollectionNames with DB creation #71

Closed edenaharoni closed 3 years ago

edenaharoni commented 3 years ago

Currently the ctor of the ArangoDBGraph is creating anArangoDBGraphClient with sending it the shouldPrefixCollectionNames as a boolean for the createDatabase param. I think this should be decoupled with new configuration added to the ArangoDBConfigurationBuilder named shouldCreateDatabase or even add it to the .dataBase method as a boolean param.

arcanefoam commented 3 years ago

The shouldPrefixCollectionNames flag coupled with creating or reusing an existing database. That is,

shouldPrefixCollectionNames == false -> reuse existing db+graph -> createDatabase = false
shouldPrefixCollectionNames == true -> create new db+graph -> createDatabase = true

Note that the current implementation does not cope well with existing databases+graphs. #38 addresses this issue.