search

ArangoDB-Community / pyArango

Python Driver for ArangoDB with built-in validation
https://pyarango.readthedocs.io/en/latest/
Apache License 2.0
238 stars 90 forks source link

Added Deduplication for indexing a list #112

Closed dilipvamsi closed 6 years ago

dilipvamsi commented 6 years ago

Hi, I haved functionality for deduplication for indexing a list.

Regards, Dilip Vamsi.

wsidl commented 6 years ago

I would suggest changing the default value to False. Deduplication modifies the document structure which may cause applications to break.

codecov-io commented 6 years ago

Codecov Report

Merging #112 into master will increase coverage by 0.57%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   80.01%   80.59%   +0.57%     
==========================================
  Files          12       12              
  Lines        2117     2169      +52     
==========================================
+ Hits         1694     1748      +54     
+ Misses        423      421       -2
Impacted Files Coverage Δ
pyArango/collection.py 67.94% <ø> (+0.31%) :arrow_up:
pyArango/tests/tests.py 97.78% <0%> (+0.02%) :arrow_up:
pyArango/document.py 74.37% <0%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d91c08...ca71df1. Read the comment docs.

tariqdaouda commented 6 years ago

Thanks everyone. Merge, with default value to False.