ArangoDB-Community / pyArango

Python Driver for ArangoDB with built-in validation
https://pyarango.readthedocs.io/en/latest/
Apache License 2.0
238 stars 90 forks source link

Return details for bulk imports #115

Closed thekie closed 6 years ago

thekie commented 6 years ago

I added the return of the details for a bulk import to the end user of this library. We needed this for taking further actions and give the user feedback how their data import went.

It's a simple one line addition. I also added tests for the case of an exception and for the case of the return of the description data from the import.

Cheers

P.S. I had to fix on etest case in the unit tests and I added a ARANGODB_URL environmen var, in case some (like me) has running arango on a different port.

codecov-io commented 6 years ago

Codecov Report

Merging #115 into master will increase coverage by 0.3%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #115     +/-   ##
=========================================
+ Coverage   80.28%   80.59%   +0.3%     
=========================================
  Files          12       12             
  Lines        2141     2169     +28     
=========================================
+ Hits         1719     1748     +29     
+ Misses        422      421      -1
Impacted Files Coverage Δ
pyArango/tests/tests.py 97.78% <100%> (+0.1%) :arrow_up:
pyArango/collection.py 67.94% <100%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 802e661...6a1d88d. Read the comment docs.

tariqdaouda commented 6 years ago

Perfect, thank you.

Cheers,