search

ArangoDB-Community / pyArango

Python Driver for ArangoDB with built-in validation
https://pyarango.readthedocs.io/en/latest/
Apache License 2.0
238 stars 90 forks source link

Added foxx executor and minor fixes for grequest session. #148

Closed dilipvamsi closed 5 years ago

dilipvamsi commented 5 years ago

Class uses the connection's session for making a call to the foxx function.

codecov-io commented 5 years ago

Codecov Report

Merging #148 into master will increase coverage by 0.15%. The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   71.93%   72.09%   +0.15%     
==========================================
  Files          12       13       +1     
  Lines        2580     2630      +50     
==========================================
+ Hits         1856     1896      +40     
- Misses        724      734      +10
Impacted Files Coverage Δ
pyArango/tests/tests.py 97.8% <100%> (+0.02%) :arrow_up:
pyArango/database.py 55.34% <100%> (+1.7%) :arrow_up:
pyArango/connection.py 77.38% <66.66%> (ø) :arrow_up:
pyArango/foxx.py 67.44% <67.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7181ff9...80c26b2. Read the comment docs.

dothebart commented 5 years ago

hm, having tests for this seems hard? maybe one could use the default aardvark routes for some tests?

dilipvamsi commented 5 years ago

Hi @dothebart , Should the functions take mount as an argument

def get(self, mount, url, **kwargs)

Or

def get(self, url, **kwargs)

Which one is better?

dothebart commented 5 years ago

I'd use mountPoint as thats what i.e. aardvark uses as strings

dilipvamsi commented 5 years ago

@dothebart , I have added functionality to call from a service or directly with url. Review for any more changes that are needed to be done.

tariqdaouda commented 5 years ago

Hi,

Thanks for this, could you please resend it to the Dev branch (after fixing the aardvark).

dilipvamsi commented 5 years ago

Hi,

Thanks for this, could you please resend it to the Dev branch (after fixing the aardvark).

okay

dothebart commented 5 years ago

hint: you can edit the target branch along with the subject of the PR - not all that intuitive ;-)

dothebart commented 5 years ago

superseeded by: https://github.com/ArangoDB-Community/pyArango/pull/149