trevordimartino commented 5 years ago

While trying to bulk import a local JSON file, I got an error and found this simple-to-fix bug. I chose lower case url as the standard variable name based on other usage in the module.

This is my first contribution to pyArango, let me know if anything else needs to be done to get this merged in.

Thanks!

codecov-io commented 5 years ago

Codecov Report

Merging #150 into master will not change coverage. The diff coverage is 50%.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files          12       12           
  Lines        2580     2580           
=======================================
  Hits         1856     1856           
  Misses        724      724

Impacted Files	Coverage Δ
pyArango/collection.py	`52.71% <50%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d9465c...6534396. Read the comment docs.

tariqdaouda commented 5 years ago

Hi @trevordimartino,

Thanks for this, could you please change the target branch to 'dev'. We do not merge directly into 'master'.

Cheers,

tariqdaouda commented 5 years ago

Thanks.

ArangoDB-Community / pyArango

Fix url variable case for bulkImport methods. #150

Codecov Report