search

ArangoDB-Community / pyArango

Python Driver for ArangoDB with built-in validation
https://pyarango.readthedocs.io/en/latest/
Apache License 2.0
238 stars 90 forks source link

as sugested by @omerzohar we also need to delete values if they are a… #154

Closed dothebart closed 5 years ago

dothebart commented 5 years ago

… dict.

codecov-io commented 5 years ago

Codecov Report

Merging #154 into dev will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #154      +/-   ##
==========================================
+ Coverage   77.92%   77.95%   +0.03%     
==========================================
  Files          14       14              
  Lines        2854     2858       +4     
==========================================
+ Hits         2224     2228       +4     
  Misses        630      630
Impacted Files Coverage Δ
pyArango/document.py 78.44% <100%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a0709fe...d99b01f. Read the comment docs.

dothebart commented 5 years ago

@omerzohar can you give a hint at what to add to https://github.com/ArangoDB-Community/pyArango/blob/master/pyArango/tests/tests.py#L194 so the fixed error behaviour is tested?

tariqdaouda commented 5 years ago

@omerzohar can you give a hint at what to add to https://github.com/ArangoDB-Community/pyArango/blob/master/pyArango/tests/tests.py#L194 so the fixed error behaviour is tested?

Just adding a nested dict, deleting it and making sure that subStores is empty would test it.