search

ArangoDB-Community / pyArango

Python Driver for ArangoDB with built-in validation
https://pyarango.readthedocs.io/en/latest/
Apache License 2.0
238 stars 90 forks source link

Fix abnormal aqlQuery #169

Closed Hydrugion closed 4 years ago

Hydrugion commented 4 years ago

This pull is to fix the issue #160, instead of returning an empty array when there is no more item, the query should call for the next batch instead. Inside the nextBatch() function already handle the iteration stop when running out of result.

codecov-io commented 4 years ago

Codecov Report

Merging #169 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   78.13%   78.13%           
=======================================
  Files          17       17           
  Lines        2946     2946           
=======================================
  Hits         2302     2302           
  Misses        644      644
Impacted Files Coverage Δ
pyArango/query.py 81.81% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4eae333...a4e143e. Read the comment docs.

tariqdaouda commented 4 years ago

Nice catch!