search

Arash-codedev / openGA

A free C++ Genetic Algorithm library
Mozilla Public License 2.0
219 stars 49 forks source link

add an option to use non recursive sort #5

Closed LucBanda closed 5 years ago

LucBanda commented 5 years ago

This is a little bit slower but it does not stack overflow when population is huge (more than 6000 in my case). It also depend when the pivot is found.

With the std::sort, no recursion, so no stack issue

Arash-codedev commented 5 years ago

Dear Luc Banda, Thank you very much for contributing to openGA project. For the sake of consistency, would you please use Allman coding style and also use a lambda function instead of a structure inside the function.

LucBanda commented 5 years ago

Please let me know if you want me to squash the commits

Arash-codedev commented 5 years ago

Dear LucBanda, I merged the pull request and I noticed that your changes are not shown as a contribution to openGA. The reason is that you merged from a forked repo instead of applying your change on a clone. I will be happy to have you as a openGA contributor. I reverted the pull request. Please clone this project and apply the changes on it again; then, create a pull request.

LucBanda commented 5 years ago

Dear Arash,

I tried to do what you suggested, but I face a rights issue. I cannot push directly on any branch of your repository.

regards Luc

Le mar. 8 oct. 2019 à 11:26, Arash notifications@github.com a écrit :

Dear LucBanda, I merged the pull request and I noticed that your changes are not shown as a contribution to openGA. The reason is that you merged from a forked repo instead of applying your change on a clone. I will be happy to have you as a openGA contributor. I reverted the pull request. Please clone this project and apply the changes on it again; then, create a pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Arash-codedev/openGA/pull/5?email_source=notifications&email_token=AAOL6CFKIN5OXB5W4XSAB2DQNRG5BA5CNFSM4IXBJQ6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEATQ7XQ#issuecomment-539430878, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOL6CGFNZF3ZMYTQNTHOMLQNRG5BANCNFSM4IXBJQ6A .

Arash-codedev commented 5 years ago

Dear LucBanda, I added you as a collaborator. Please accept it and try sending a pull request again.

https://github.com/Arash-codedev/openGA/invitations