AravisProject / aravis

A vision library for genicam based cameras
GNU Lesser General Public License v2.1
840 stars 316 forks source link

Make sure to only disable frame rate if necessary. #879

Closed feuerste closed 3 months ago

feuerste commented 3 months ago

Previously irrespective of whether a trigger was set or not the frame rate was tried to be disabled. However, this failed (at least for an Allied Vision-Alvium G1-1240c) if already a trigger was set, causing the whole set_trigger call to fail. The failure was actually introduced with https://github.com/AravisProject/aravis/pull/877/files#diff-d7be5be1f918127f4161b7f5a654290347f3334e434d14a61eb04e013b85dd99R1388 where the local_error was for the first time checked (Before that it was set but ignored).

This also fixes a bug where the wrong error pointer was checked in arv_camera_get_frame_rate_enable.

EmmanuelP commented 3 months ago

Thanks.