Primarily these patches add more error reporting and documentation. With the extended error messages I think it makes sense to change the default socket-buffer policy to ARV_GV_STREAM_SOCKET_BUFFER_AUTO, which this patch series does.
There's one more thing I would change also, but want to get your thoughts about all this first:
If setsockopt() returns success, but doesn't actually give us the requested buffer, we currently:
Report a arv_warning_interface()
arv_socket_set_recv_buffer_size() returns FALSE
But the caller of arv_socket_set_recv_buffer_size() doesn't do anything with this FALSE, and things continue as normal. I would make this a hard error, and I'd change the arv_warning_interface() to something that would be seen even without any ARV_DEBUG flags.
These are the result of me encountering and debugging packet-dropping issues: https://github.com/AravisProject/aravis/issues/894
Primarily these patches add more error reporting and documentation. With the extended error messages I think it makes sense to change the default socket-buffer policy to
ARV_GV_STREAM_SOCKET_BUFFER_AUTO
, which this patch series does.There's one more thing I would change also, but want to get your thoughts about all this first:
If setsockopt() returns success, but doesn't actually give us the requested buffer, we currently:
arv_warning_interface()
arv_socket_set_recv_buffer_size()
returns FALSE But the caller ofarv_socket_set_recv_buffer_size()
doesn't do anything with this FALSE, and things continue as normal. I would make this a hard error, and I'd change thearv_warning_interface()
to something that would be seen even without anyARV_DEBUG
flags.Thanks much