search

ArbitrumFoundation / governance-seatbelt

Make governance safer
GNU General Public License v3.0
8 stars 4 forks source link

ID scheme for child simulation is weird #5

Open gzeoneth opened 1 year ago

gzeoneth commented 1 year ago

Child simulation (e.g. the L1 execution of a L2 proposal, the retryable execution of a L1 transaction) currently use a naive id scheme here: https://github.com/ArbitrumFoundation/governance-seatbelt/blob/401c99fdb9fa1fac5e93344a9db908e1b9f45575/index.ts#L57 https://github.com/ArbitrumFoundation/governance-seatbelt/blob/401c99fdb9fa1fac5e93344a9db908e1b9f45575/index.ts#L119 which is weird and because arb governor do not use sequential numbering it make the id like the following:

L2 Proposal Execution:

Running for proposal ID 0xbb95ace4f588148ad3a1d9bc233dbef1002971173556b5826a829962c3edd81c...

L1 Timelock Execution:

Running for proposal ID 0xbb95ace4f588148ad3a1d9bc233dbef1002971173556b5826a829962c3edd81d...

Retryable Execution:

Running for proposal ID 0xbb95ace4f588148ad3a1d9bc233dbef1002971173556b5826a829962c3edff2d...