ArbitrumFoundation / governance

Apache License 2.0
73 stars 27 forks source link

fix: use existing upgrade executor in local test #252

Closed gzeoneth closed 9 months ago

gzeoneth commented 9 months ago

Recent nitro version (^2.2.0) used a newer nitro-contracts version which contained a rollup creator that by default deploy an upgrade executor as the rollup owner. This causes some issue with the governance deployment test as it expect the owner to be an EOA. This PR detect if the rollup is owned by an upgrade executor and passthrough the call through the existing upgrade executor.

A container name is also fixed in the local test script (poster -> sequencer) as poster is not enabled in simple mode while sequencer is always enabled.

Also importing upgrade-executor from https://github.com/OffchainLabs/upgrade-executor, we should eventually migrate the upgrade executor used in this repo to the imported version.