ArboreumDev / credit-union-frontend

Frontend in Next.js + Typescript + GraphQL
https://frontend-two-sandy.vercel.app
1 stars 0 forks source link

Dju/new run trough fixes #192

Closed djudjuu closed 3 years ago

gparuthi commented 3 years ago

Codecov Report

Merging #192 (61f0dcc) into master (7967028) will increase coverage by 0.10%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
+ Coverage   32.11%   32.22%   +0.10%     
==========================================
  Files         109      109              
  Lines        1233     1235       +2     
  Branches      158      158              
==========================================
+ Hits          396      398       +2     
  Misses        829      829              
  Partials        8        8              
Impacted Files Coverage Δ
src/components/borrower/repayments.tsx 0.00% <0.00%> (ø)
src/components/lender/InvestedLoans.tsx 0.00% <ø> (ø)
src/components/lender/LenderDashboard.tsx 0.00% <ø> (ø)
src/lib/demo/fixtures.ts 0.00% <ø> (ø)
src/gql/db_client.ts 91.96% <100.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7967028...61f0dcc. Read the comment docs.

djudjuu commented 3 years ago

@gparuthi I'd like to merge this together with https://github.com/ArboreumDev/swarmai/pull/201

but I am not sure why the 'remove analytics' commit is in here...should it be?

gparuthi commented 3 years ago

I added thar before. Can probably ignore changes made in that commit. Can we cherry pick that commit out. Or easier to ignore them when merging.

djudjuu commented 3 years ago

Or easier to ignore them when merging.

i think I did that now.... lets review this and merge it in, as the backend has already changed loan-schedule summary, so all tests pass without redirecting to local swarmai-instance

djudjuu commented 3 years ago

@gparuthi lets get this in