v0lender onboarding - Githubissues

djudjuu commented 3 years ago

closing #207

[x] figure out why tests fail
[x] removed all tests that are not relevant to the v0 release

djudjuu commented 3 years ago

hi, I am quite okay with how this is atm.

still to do

will be to re-enable oauth logins
curretnly we check whether the session belong to a user with our admin-email address...in the future this needs to be improved to do proper jwt-authentication...Idk yet how and where we could assing we woudl assign those...propably the answer is in the next-auth library docs somewhere
also, we will probably be able to pull some of the info (DOB, gender, address) from the aadhar file, so we can probably remove those from the forms

next i would move the admin email to the .env file and figure out how to deploy this (a bit complicated as we need to do a db-migration)

djudjuu commented 3 years ago

There is a Form validation library Being used when u hit submit at the end. React-hook-form.

But that didn't behave too informative, eg it didn't shift focus to the field where the validation error occurred...it just stayed blank which was confusing.

There is the errors-property (or state rather) returned by useForm, but I couldn't figure out how to access it.

In the long run, we could maybe have one Form per onboarding step...

On Thu, Mar 18, 2021, 14:03 h-vishal @.***> wrote:

@.**** commented on this pull request.

In src/components/common/onboarding/onboarding.tsx https://github.com/ArboreumDev/frontend/pull/208#discussion_r596847120:

const tabFields = {

0: [

"address",

"zipCode",

"phone",

"gender",

"dob",

"lastname",

"firstname",

],

1: ["accountNumber", "ifsc", "bankName", "accountType"],

2: ["fatherLastName", "fatherFirstName", "employmentType", "income"],

3: ["aadhaarPassword"],

}

const checkFields = async (

Is there a reason for not using a form validation library for this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ArboreumDev/frontend/pull/208#pullrequestreview-615357363, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLMYXFKV3OQ7UQ6YTYNUWTTEH23JANCNFSM4ZI4CSXA .

h-vishal commented 3 years ago

@djudjuu you are checking the hasura seeds failure on the tests?

Let's create an issue to add authorization for access levels and an audit trail.

djudjuu commented 3 years ago

let me know what fields to remove from the onboarding sequqnce (if it is simple to get them from the aadhar files)....otherwise this now quieres all the info we need

@h-vishal

djudjuu commented 3 years ago

also I really should have done the production/deployment changes on a different branch....I am not again used to coding together again...

ArboreumDev / credit-union-frontend

v0lender onboarding #208

@.**** commented on this pull request.