search

ArboreumDev / credit-union-frontend

Frontend in Next.js + Typescript + GraphQL
https://frontend-two-sandy.vercel.app
1 stars 0 forks source link

circle transfers #214

Closed djudjuu closed 3 years ago

djudjuu commented 3 years ago

forked from #211

typings done based on circle docs: https://developers.circle.com/reference#dda-transfers-get

h-vishal commented 3 years ago

Let's add a TODO: need an abstract interface for KYC and then a specific KYC per country

        name: data.firstname + " " + data.lastname, // TODO: #154 Change DB to have separate first and last names

src/components/common/onboarding/onboarding.tsx (Line 133)

h-vishal commented 3 years ago

Do we need these changes

import { GraphQLClient } from "graphql-request"

src/gql/db_client.ts (Line 1)

djudjuu commented 3 years ago

Let's add a TODO: need an abstract interface for KYC and then a specific KYC per country

https://github.com/ArboreumDev/frontend/issues/217

djudjuu commented 3 years ago

re: image

so i think the bigger question will be how we manage the circle client...e.g. its connection to production / or staging env. Currently it is being important from the file...but I think having it inside the db.client and initializing it there would be cleanest...the credentials and url would come from the .env file...

i'll add that as a TODO