search

ArboreumDev / credit-union-frontend

Frontend in Next.js + Typescript + GraphQL
https://frontend-two-sandy.vercel.app
1 stars 0 forks source link

[WIP] added linter #35

Closed djudjuu closed 4 years ago

djudjuu commented 4 years ago

we should probably take one tat works for typescipt too... there is tsling (from palantir though :/ )...and this one:

https://github.com/google/gts

what do you think?

gparuthi commented 4 years ago

I am not sure which one to use, or if linter adds any significant value, given that we are using typescript. I use prettier for formatting though and find it pretty useful. Eslint seems to be the standard when I google "nextjs linter". This guide looks good.

On a sidenote: I saw this come up Rome. Interesting discussion followed https://news.ycombinator.com/item?id=24094377 It looks simple to use.

gparuthi commented 4 years ago

I just saw your comment on #34. It makes sense to use linter for keeping consistent casing. Thanks.

gparuthi commented 4 years ago

Closed in favor of #59