Closed gparuthi closed 4 years ago
@gparuthi how should we do this? Do you want to review it? It is a monsterPR. Also, there are a lot of places that are a bit hacky and that will be improved in the future.....I think I'd prefer just merging it and then going back to reviewing the subsequent ones (which will be smaller).
Also, I (re-)learned to make my commits smaller logical chunks. that will make reviewing and rebasing easier.... sorry for the mess
closed in favor of #57
Recreating PR after #34 was merged preemptively, without all tests passing.