search

Arc-io / Widget-WordPress-Plugin

WordPress Plugin for Arc's Widget
https://arc.io/
3 stars 3 forks source link

Arc service worker is hosted incorrectly by the plugin #4

Open mahmoud34abc opened 8 months ago

mahmoud34abc commented 8 months ago

I noticed that arc checks if the service worker is present at https://flashmedinfo.com/arc-sw.js , and I would get warnings that the file actually isn't there and is showing a 404 page. It turns out the WordPress plugin hosts it at https://flashmedinfo.com/arc-sw and so that's why the service worker does not "exist".

(I'll remove links when the issue is solved)

mahmoud34abc commented 8 months ago

Hey, I'm really not familiar with how to commit or make a pull request, but I found the issue

https://github.com/Arc-io/Widget-WordPress-Plugin/blob/master/trunk/arc.php#L45

The proxy URL should be /arc-sw.js , not just /arc-sw

You might as well want to check the next line about the /arc-widget. I'm not sure if it's supposed to have .js or not

mahmoud34abc commented 8 months ago

Here you go, that pull request should be enough to get the service worker back to working

https://github.com/Arc-io/Widget-WordPress-Plugin/pull/5

Still don't know how to link an issue to a pull request 😅