Bugfix: Make sure to use the keyProvider when adding an item to the list

ArcBees / gwtchosen

Port of the chosen javascript plugin for Google Web Toolkit

Other

107 stars 50 forks source link

Bugfix: Make sure to use the keyProvider when adding an item to the list #298

Closed timeu closed 8 years ago

timeu commented 8 years ago

Fixes #297

meriouma commented 8 years ago

Thanks for the contribution. Could you add a test please?

olafleur commented 8 years ago

LGTM

timeu commented 8 years ago

@meriouma: Should I add a new Testcase to the integration-test module ?

meriouma commented 8 years ago

Yes I think you'll need to create a new one for this case, then use it in ChosenIT. Just ping me if you need further help. Thanks!

timeu commented 8 years ago

@meriouma: I added a testcase, however I don't know how to run the integration tests from th command line (tried mvn test in the command line). I only managed to run them manually by mvn gwt:run -Pintegration-test

olafleur commented 8 years ago

LGTM. @meriouma ?