ArcBees / gwtquery-droppable-plugin

GwtQuery droppable plugin
MIT License
7 stars 11 forks source link

Update draggable to 2.0-SNAPSHOT #7

Closed jclariviere closed 9 years ago

jclariviere commented 9 years ago

Droppable was using draggable 1.0.4. The 2.0 version on Arcbees had some changes in it's interface that was breaking Droppable. See this issue : https://github.com/ArcBees/gwtquery-droppable-plugin/issues/2

Droppable version 1.0.5 to 1.0.8 didn't seem to match the trunk from googlecode, and it seems the Github's initial version was using 1.0.8. So I checked out the initial Github version, applied the Element -> DragContext changes, then rebased on master.

christiangoudreau commented 9 years ago

GJ! LGTM

@jDramaix needs to review though.

Also, would be great to do a PR to move to 4 spaces instead of 2

meriouma commented 9 years ago

Few nits, otherwise good job, LGTM

jDramaix commented 9 years ago

If the examples work, LGTM