ArcBees / gwtquery

A jQuery clone for GWT, and much more.
MIT License
85 stars 38 forks source link

Hover for Rating plugin isn't working in IE7 #145

Closed jDramaix closed 11 years ago

jDramaix commented 11 years ago

Original author: vreeken....@gmail.com (November 17, 2011 15:27:05)

What steps will reproduce the problem?

  1. Simple use the IE7 render mode (tested with IE8): the rating plugin won't work.

What is the expected output? What do you see instead? I''m expecting the stars to hover. Also, the onclick event isn't fired.

What version of the product are you using? On what operating system? latest: 1.0.1

Please provide any additional information below. The onhover isn't attached to the star images. That's because the stars are marked as 'readonly'. The readonly property is set around row 290 Ratings.java: JsUtils.truth(input.attr("disabled")).

The thing is that IE7 returns 'false' for input.attr("disabled"). Other browsers return an empty string. The fix should for example:

if (JsUtils.truth(input.attr("disabled")) && !input.attr("disabled").equalsIgnoreCase("false")) { control.setReadOnly(true); } else

Happy fixing!

regards Bart

Original issue: http://code.google.com/p/gwtquery/issues/detail?id=113

jDramaix commented 11 years ago

From manuel.carrasco.m on March 07, 2012 13:54:49 Please could you move this bug to the gwtquery-plugins issue page?

Thanks -Manolo