ArcBees / gwtquery

A jQuery clone for GWT, and much more.
MIT License
85 stars 38 forks source link

RequestFactory.gwt.xml missing from Query.gwt.xml #237

Closed Chris-V closed 10 years ago

Chris-V commented 10 years ago

Using the latest snapshot, I can't compile my application unless I add <inherits name='com.google.web.bindery.requestfactory.RequestFactory' /> to my gwt module. This should be added to the GQuery module (or optional unless I want to use RequestFactory?).

[INFO]       [ERROR] Errors in 'jar:file:/.../1.4.0-SNAPSHOT/gwtquery-1.4.0-SNAPSHOT.jar!/com/google/gwt/query/client/plugins/deferred/PromiseRF.java'
[INFO]          [ERROR] Line 55: No source code is available for type com.google.web.bindery.requestfactory.shared.RequestContext; did you forget to inherit a required module?
[INFO]          [ERROR] Line 60: No source code is available for type com.google.web.bindery.requestfactory.shared.Request<T>; did you forget to inherit a required module?
[INFO]          [ERROR] Line 73: No source code is available for type com.google.web.bindery.requestfactory.shared.Receiver<V>; did you forget to inherit a required module?
[INFO]          [ERROR] Line 75: No source code is available for type com.google.web.bindery.requestfactory.shared.ServerFailure; did you forget to inherit a required module?
manolo commented 10 years ago

It's weird, this error should not appear unless you use the PromiseRF class.

jDramaix commented 10 years ago

the error appears because they compile with the "-strict" option.

I've just created a new project with gwtquery and it's works fine but when I compile with the "-strict" option I get the error.

manolo commented 10 years ago

maybe we can move PromiseRF to 'com.google.web.bindery.requestfactory.shared' namespace so as people using RF can use the clase, other option would be create a c.g.g.q,rf namespace in gquery and a new gwt.xml file. I prefer first one.

jDramaix commented 10 years ago

I vote for the first one

On Mon, Nov 25, 2013 at 12:12 PM, Manuel Carrasco notifications@github.comwrote:

maybe we can move PromiseRF to 'com.google.web.bindery.requestfactory.shared' namespace so as people using RF can use the clase, other option would be create a c.g.g.q,rf namespace in gquery and a new gwt.xml file. I prefer first one.

— Reply to this email directly or view it on GitHubhttps://github.com/gwtquery/gwtquery/issues/237#issuecomment-29193695 .

pamikola commented 10 years ago

The GWT compiler documentation says "-strict Only succeed if no input files have errors".

Do you know what are the "errors" in gwtquery which prevent it from being successfully compiled with -strict? And how hard is it to fix them?

Have you considered going this route?

jDramaix commented 10 years ago

@panamik we fix the issue by moving PromiseRF to com.google.web.bindery.requestfactory.shared

manolo commented 10 years ago

done