search

ArcBees / gwtquery

A jQuery clone for GWT, and much more.
MIT License
85 stars 38 forks source link

Parsing only methods specified in JsonBuilder interface from a given json #325

Closed apanizo closed 9 years ago

apanizo commented 9 years ago

When I have a chance I'll do the same in the client.

Have a look and if you notice something wrong, let me know.

manolo commented 9 years ago

@meriouma @jDramaix It's weird, this commit does not compiles in my local, that is obvious because @apanizo has modified an interface and in client side there is no implementation, but TC does not complains !

manolo commented 9 years ago

Thanks for contributing :-)

manolo commented 9 years ago

There are many files without license in sources, formatting issues, CR and NL, I'll commit a separated patch

christiangoudreau commented 9 years ago

well, if you do that's fine, but I always apply the boy scout rules, if you're going to propose a patch, add what is missing while being at it.

jDramaix commented 9 years ago

We should introduce checkstyle in the project.

On Wed Dec 31 2014 at 4:35:44 PM christiangoudreau notifications@github.com wrote:

well, if you do that's fine, but I always apply the boy scout rules, if you're going to propose a patch, add what is missing while being at it.

— Reply to this email directly or view it on GitHub https://github.com/ArcBees/gwtquery/pull/325#issuecomment-68448635.

apanizo commented 9 years ago

@manolo @christiangoudreau @jDramaix thanks for spending time reviewing it.

I did this feature during Christmas time with a really constraint of time, so I did not pay a lot of attention to the style rules. Sorry about that.

Also I tried to write similar code to the existing one, despite of I prefer to follow another rules (more and small classes with a limited responsibility. Smaller and simpler methods with more verbosity variable and method names...), in order to do not introduce break changes.

Seriously, If you notice something wrong or something that you do not like, just let me know. I really like corrections because that mean you are interested in the pull request :). Really happy to help.

And of course, as @jDramaix said introduce a checkstyle in the project would be good.

Thanks for your time and HNY. I will follow you in the gwtcreate conference.

Adolfo.