search

ArcBees / gwtquery

A jQuery clone for GWT, and much more.
MIT License
85 stars 38 forks source link

Compiler error with Closure Compiler and gwtquery 1.4.3 #360

Open RockyMM opened 8 years ago

RockyMM commented 8 years ago

Hi!

I'm not sure if this is main branch of gwtquery. Today I updating my projects from GWT 2.5.1 to 2.6.1 and gwtquery 1.2.0 to 1.4.3 I have encountered following issue while packaging:

[ERROR] error optimizing:JSC_VAR_ARGUMENTS_SHADOWED_ERROR. Shadowing "arguments" is not allowed at com/google/gwt/query/client/Function.java line 120 : 0

Googling similar issues tells me that this should be easily fixed by renaming "arguments" to "params" or something similar in this class; https://github.com/ArcBees/gwtquery/blob/5c5aa479ae313a274944effc47f67fa7a6a97396/gwtquery-core/src/main/java/com/google/gwt/query/client/Function.java#L120

I could do a PR but I'm not sure if this is the only class affected by this issue.

Compiling with closureCompiler=off succeeded.