search

ArcBees / gwtquery

A jQuery clone for GWT, and much more.
MIT License
85 stars 38 forks source link

squid:S00115 - Constant names should comply with a naming convention #375

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S00115 Constant names should comply with a naming convention. You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS00115 Please let me know if you have any questions. George Kankava

Review on Reviewable

meriouma commented 8 years ago

I think we might have to hold off on this one. Changes in PropertiesAnimation are breaking changes

manolo commented 8 years ago

I'm against this change. I don't see any big problem having these names, we try to align names with jQuery way of doing things. In fact we use the $ name which is not recommended in java conventions and it's what we want.