squid:S1192 String literals should not be duplicated

ArcBees / gwtquery

A jQuery clone for GWT, and much more.

MIT License

85 stars 38 forks source link

squid:S1192 String literals should not be duplicated #376

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rule squid:S1192 String literals should not be duplicated. You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid%3AS1192 Please let me know if you have any questions. George Kankava

manolo commented 8 years ago

Does this patch give us any real optimisation in final js code? Normally gwt compiler takes care of these names and will merge all occurrences in one js var.

meriouma commented 8 years ago

@georgekankava Can you explain a bit more what's your motivation will all those squid/sonar related pull requests?