search

ArcBees / teamcity-plugins

40 stars 26 forks source link

Pull request TC10 heap space issues #60

Open bondarewicz opened 7 years ago

bondarewicz commented 7 years ago

We've noticed heap space issues with TC10, we had to temporarily disable the plugin as it was constantly maxing out the resources, we use snapshot-20161503143845.

Pull Request settings: VCS Type: Bitbucket Base branch: dev

VCS Settings: Default branch: dev Branch specification: +:refs/heads/*

TC usage before: image

TC usage after disabling the plugin: image

does anyone have any ideas/workarounds?

alexeygrigorovaurea commented 6 years ago

Hey @bondarewicz I know what the problem we just faced same) https://github.com/ArcBees/teamcity-plugins/blob/master/pullrequests/src/main/java/com/arcbees/pullrequest/PullRequestChainParser.java#L49 here is a buggy line when you have a pull request from fork to main repo between branches with equal name this loop become infinite and it creates billions records array

christiangoudreau commented 6 years ago

Please, do send a PR for a suggested fix.

Thanks!