Closed 0xbok closed 1 year ago
Generally looks good! Just want some answers before I LGTM.
Also, what's your general thinking about what checks should be done in
model.rs
vssend_consumer.rs
? I'm seeing more "asserts" etc inmodel.rs
than I expected, I thought that the send consumer would be doing most of the validation.
i am going with the idea that we only return promises for valid requests. If checks are done only on the consumer side, we'll return unfulfilled promises which we'll have to handle on the smart contract side making it gas expensive for valid broken promises. lmk if you have a way to circumvent this.
@BlakeMScurr merging this as changing reverting the index changes has messed up the dependencies. you can still review this and i'll make any required changes in a coming pr.
send_consumer.rs
which consumes the queue and creates or loads a merkle tree which is meant to store the proven sends.main.rs
is gone.