search

ArcaEge / day-progress

A GNOME shell extension that shows a progress bar of your day
https://extensions.gnome.org/extension/7042/day-progress/
GNU General Public License v3.0
38 stars 1 forks source link

Calculate progress based on period and not % of day #3

Closed Wyesumu closed 4 months ago

Wyesumu commented 4 months ago

By default, it works the same way as it is now - it shows % of day progress (period from 00:00 to 23:59) but now user can adjust period to his own. For example, from 9:00 to 18:00 to track progress of his workday.

ArcaEge commented 4 months ago

Thanks, I'll have a look over the code!

ArcaEge commented 4 months ago

Code looks good, I'll do a bit of testing and then submit it. Also thanks for fixing up the code!

ArcaEge commented 4 months ago

Looks good to me, though I need to update the defaults.

ArcaEge commented 4 months ago

Thanks, merged!

ArcaEge commented 4 months ago

Hello, upon further testing I've realised that the code doesn't handle wrap around midnight correctly (for example if reset time is past midnight). I'll be updating it before I submit the extension again (yes I shouldn't be using the main branch for this) but anyway, thank you!

ArcaEge commented 4 months ago

I've uploaded it, waiting for approval image

Wyesumu commented 4 months ago

Thank you for noticing it and fixing, I missed that part. And also sorry for missed log line

ArcaEge commented 4 months ago

They probably would've allowed the log as it's probably not that excessive but it's better to not add additional lines to the log every second - it makes filtering through them easier

Wyesumu commented 4 months ago

For sure, I was removing all log entries but missed that line for some reason

ArcaEge commented 4 months ago

Also, if you occasionally have time to work on it, would you like me to add you as a collaborator?

Wyesumu commented 4 months ago

Yeah, I could. Do you have a roadmap/to do list of stuff that you want to implement in this extension?

ArcaEge commented 4 months ago

Ok, I'm currently outside but I'll do all that once I get back home in a few hours (if I hopefully don't forget)

ArcaEge commented 4 months ago

Done, I need you to accept the invite.

Wyesumu commented 4 months ago

Already did it

ArcaEge commented 4 months ago

I'll create a GH project with a todo list with features to implement, give me a few mins

ArcaEge commented 4 months ago

https://github.com/users/ArcaEge/projects/1 I've created it, I'm adding the feature requests now

ArcaEge commented 4 months ago

Done, I've added a few feature requests.