Closed Wyesumu closed 4 months ago
Yeah, that's why I marked it as experimental. I also thought of using a gradient with the stops very close to each other to draw the bar but turns out gradients also aren't supported. Anyway, thanks for the PR and I'll have a look at it when I get home (in ~1 hour)
Sorry my train was delayed, I'll have a look now though
Hello, the height wasn't updating for me, I had to remove the hardcoded heights from the CSS file. Apart from that, I've fixed a minor cosmetic bug (the inner border radius was set to 0.3 instead of 0.15 when circular borders were disabled, causing it to have a different curvature, see images below for what I mean).
Curvatures don't match: Fixed version:
Other than that, I've also changed the measurement for the bar height to tenth of an em instead of fifth, to allow for more precise control over it. As a result, I've also changed the default value to 0.9em height and made the min height 0.2em since below that, the bar is invisible. Also, when you change the settings UI, can you also (if you're not using any third-party themes) update docs/images/screenshot5.png as well? Just take a window-only screenshot in the default screenshot tool.
I've submitted it, it should be live by tomorrow
It's live now
@ArcaEge Forgot about the screenshot. Will keep it in mind, thank you!
Thanks!
PR for issue https://github.com/users/ArcaEge/projects/1/views/1?pane=issue&itemId=65229987
Noticed one bug that I was not able to resolve so far - if you make height as tall as possible and leave it with the default width then the bar is overflowing corners on small values if you enable rounded corners:
And if you make it extremely small then it looks really broken:
In CSS I would just enable overflow: hidden on the container but looks like here it does not work