search

ArcadeRenegade / SidebarDiagnostics

A simple sidebar for Windows desktop that displays hardware diagnostic information.
GNU General Public License v3.0
2.29k stars 201 forks source link

Implemented SidebarBorderWidth Settings #386

Open nicolgit opened 2 years ago

nicolgit commented 2 years ago

Hi guys, I have made customizable the padding size from the settings. This because I have found the default padding too wide for my preferences :-) the benefit is that you can earn valuable pixels on the screen. hope you like it.

I have updated the settings dialog

sidebar the model, and the sidebar.xaml

ArcadeRenegade commented 2 years ago

Hi, thanks for the PR. What is the border width though? I don't think there's a border on the sidebar. Is it the padding?

Also this updates Squirrel which may be a breaking change for the auto update.

nicolgit commented 2 years ago

Yes correct, I mean padding 🤪

nicolgit commented 2 years ago

I had to upgrade squirrel in order to allow to build, not sure why...

lars18th commented 1 year ago

Hi @nicolgit ,

This PR will provide support for negative padding?

nicolgit commented 1 year ago

no @lars18th this sets only positive padding. Minimum value is 0

lars18th commented 1 year ago

no @lars18th this sets only positive padding. Minimum value is 0

And why not? Obviously, it doesn't have sense to write outside of the window space. However, if you want to reduce the border, then the padding could be negative... until the size of the real border.

Any way. When this patch will be merged?

lars18th commented 10 months ago

Hi @nicolgit ,

Still waiting to merge.