Arcadia-Science / arcadia-pycolor

tools for using the Arcadia palette in Python
MIT License
3 stars 0 forks source link

Adding in tests #11

Closed mezarque closed 1 month ago

mezarque commented 1 month ago

PR checklist

Overview

This PR adds a variety of tests to the repo to ensure robustness. I tried to write tests that ensure that expected functionality behaves properly, as well as a smaller number of tests to handle invalid inputs. As part of this, I also reworked certain functionality that was bugged, which is a great demonstration of the importance of tests!

Changes

Testing

All the tests I've written are passing right now. I feel like there's more input validation that could be added to a variety of methods. It would be great to have a second opinion for parts of the API that might not behave as a user would expect and to write tests/ input validation logic to handle those.

Questions

Next

Probably we'll want to add more tests and evaluate code coverage (would love Keith's help on this!), but I've run out of steam on writing tests. After this, I'll share a somewhat larger PR that implements a whole slew of utilities for matplotlib, including handling fonts, registering colors, updating the stylesheet, etc.

mezarque commented 1 month ago

Thanks for all the tips! I addressed as many of these comments as I could, aiming to deduplicate things.